- Aug 28, 2024
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
When barriers are used in invalid shaders with non-uniform control flow we might get a hang. Forcing 32-wide group can help by making it more probable that barrier instruction is executed by at least one channel in each thread, and thus hang will be avoided. This shouldn't affect Xe2+, where active-thread-only barriers are used anyway. Cc: mesa-stable Closes: #11497 Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by: Francisco Jerez <currojerez@riseup.net> Part-of: <!30581> (cherry picked from commit 7e52b678)
-
If p_atomic_cmpxchg doesn't set the ray_query_shadow_bos[bucket] to new_bo allocated by this thread, it returns the bucket BO allocated by the other thread and we use it. But due to a mistake, we also release that BO, not the candidate just allocated by this thread and never used again. Fixes: 5d3e4193 ("anv: enable ray queries") Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!30581> (cherry picked from commit 1904fe11)
-
Truncation is needed for overwriting correctly in cases when old file is bigger than the one we want to dump (e.g. when the old one was edited inplace). Also, creation permissions are way too broad. Fixes: 4f41c44d ("intel/compiler: Add variable to dump binaries of all compiled shaders") Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!30581> (cherry picked from commit 09122e2b)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Part-of: <!30712> (cherry picked from commit 2158fe2a)
-
The workaround BO has some debug information at the beginning. The workaround address is placed after that. Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Cc: mesa-stable Reviewed-by: Ivan Briano <ivan.briano@intel.com> Part-of: <!30844> (cherry picked from commit d8ec8ace)
-
This handle is given to the user to close, so make sure to dup it first. Fixes: d74ea2c1 ("llvmpipe: Implement dmabuf handling") Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by: Lucas Fryzek <lfryzek@igalia.com> Part-of: <!30839> (cherry picked from commit 4bf257a1)
-
It's possible to have the linux/udmabuf.h header but not libdrm in some setups, like under Termux. Fixes: 112063a0 ("llvmpipe: Only use udmabuf if header is found") Acked-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Reviewed-by: Lucas Fryzek <lfryzek@igalia.com> Signed-off-by: Valentine Burley <valentine.burley@gmail.com> Part-of: <!30853> (cherry picked from commit 4cfaf10c)
-
Duplicates the libvc4 dependencies. Fixes: ebcb4c21 ("meson: Enable VC4's NEON assembly support.") Reviewed-by: Juan A. Suarez <jasuarez@igalia.com> Co-authored-by: David Heidelberg <david@ixit.cz> Part-of: <!30819> (cherry picked from commit fda6f863)
-
When encode isn't enabled, refuse the image usage, also use the correct error on the decode check. Fixes: 05cd4241 ("radv/video: enable video encoding behind perftest flag") Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <!30838> (cherry picked from commit 68cd36d9)
-
Resolves failures as: ... -o src/etnaviv/isa/tests/etnaviv_disasm.p/disasm.cpp.o -c ../src/etnaviv/isa/tests/disasm.cpp In file included from ../src/etnaviv/isa/tests/disasm.cpp:12: ../src/etnaviv/isa/asm.h:15:10: fatal error: etnaviv/isa/enums.h: No such file or directory 15 | #include "etnaviv/isa/enums.h" | ^~~~~~~~~~~~~~~~~~~~~ Cc: mesa-stable Closes: #11740 Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com> Signed-off-by: David Heidelberg <david@ixit.cz> Part-of: <!30829> (cherry picked from commit 8f8a51ac)
-
Needed for the follow-up change. Cc: mesa-stable Reviewed-by: Christian Gmeiner <cgmeiner@igalia.com> Signed-off-by: David Heidelberg <david@ixit.cz> Part-of: <!30829> (cherry picked from commit 43bff3b9)
-
We were actually using PIPE_FORMAT_B5G6R5_UNORM for HAL_PIXEL_FORMAT_RGB_565 since Android support was added to Mesa. This restores the original behavior. Fixes: 273e5439 ("egl/android: Remove hard-coded color-channel data") Acked-by: Daniel Stone <daniels@collabora.com> Reviewed-by: Yiwei Zhang <zzyiwei@chromium.org> Signed-off-by: Lepton Wu <lepton@chromium.org> Part-of: <!30827> (cherry picked from commit 72506ac8)
-
Prevents the next patch from failing many multisampled, signed integer rendering tests. For example: dEQP-VK.renderpass2.suballocation.multisample_resolve.r8_sint.samples_4 Cc: mesa-stable Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <!30646> (cherry picked from commit dfcd93d1)
-
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Closes: #11746 Fixes: 982106e6 ("anv: only set 3DSTATE_CLIP::MaximumVPIndex once") Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <!30762> (cherry picked from commit a88898a2)
-
- Aug 27, 2024
-
-
Make sure to preserve the depth or stencil components of D24S8 using the fixed codepath just added. While we're here, fix the detection of whether an attachment is bound. Fixes: cb0f414b ("tu: Add support for suspending and resuming renderpasses") Part-of: <!26154> (cherry picked from commit 812c8f6a)
-
See code comment for details. Issue: #11535 Fixes: c6c150b4 ("glsl_to_nir: support conversion of opaque function params") Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <!30338> (cherry picked from commit d681cf96)
-
The bindless spec has no language requiring functions params to be defined as bindless so we need to be able to look at the values being passed to functions to decide if they are bindless or not. This intrinsic allows us to wait until function inlining is complete to make this assessment. Closes: #11535 Acked-by: Marek Olšák <marek.olsak@amd.com> Part-of: <!30315> (cherry picked from commit a629d829)
-
To be used as a placeholder until after function inlining so we can replace function params with bindless handles if needed. Acked-by: Marek Olšák <marek.olsak@amd.com> Part-of: <!30315> (cherry picked from commit 017770ff)
-
Will be used in a following patch. Acked-by: Marek Olšák <marek.olsak@amd.com> Part-of: <!30315> (cherry picked from commit ef13ff00)
-
Eric Engestrom authored
-
Instead of reproting an VK_ERROR_INCOMPATIBLE_DRIVER we were crashing as device->model was init after this error check. Tested on G57 but should work the same on all unsupported arch. Signed-off-by: Mary Guillemard <mary.guillemard@collabora.com> Fixes: f7f9b3d1 ("panvk: Move to vk_properties") Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> Part-of: <!30686> (cherry picked from commit c95ef9e3)
-
fossil-db (navi31): Totals from 4840 (6.10% of 79395) affected shaders: Instrs: 13733449 -> 13761177 (+0.20%); split: -0.00%, +0.21% CodeSize: 71997868 -> 72102520 (+0.15%); split: -0.00%, +0.15% Latency: 128385177 -> 128408780 (+0.02%); split: -0.00%, +0.02% InvThroughput: 21105847 -> 21109475 (+0.02%); split: -0.00%, +0.02% VALU: 7741209 -> 7741210 (+0.00%) Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Backport-to: 24.1 Backport-to: 24.2 Part-of: <!30818> (cherry picked from commit 11262a01)
-
This should be done after reads are checked and sgpr_read_by_valu_as_lanemask_then_wr_by_salu is reset. The old version also skipped checking the reads if the write check passed. fossil-db (navi31): Totals from 193 (0.24% of 79395) affected shaders: Instrs: 3212435 -> 3212735 (+0.01%) CodeSize: 16462868 -> 16463848 (+0.01%); split: -0.00%, +0.01% Latency: 19492377 -> 19492462 (+0.00%); split: -0.00%, +0.00% InvThroughput: 4419705 -> 4419718 (+0.00%); split: -0.00%, +0.00% Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Backport-to: 24.1 Backport-to: 24.2 Part-of: <!30818> (cherry picked from commit 61e73c23)
-
LLVM does but that's probably a bug. fossil-db (navi31): Totals from 311 (0.39% of 79395) affected shaders: Instrs: 380453 -> 381075 (+0.16%) CodeSize: 1961012 -> 1964744 (+0.19%) Latency: 4799095 -> 4800313 (+0.03%) InvThroughput: 958358 -> 958904 (+0.06%) VALU: 242322 -> 242633 (+0.13%) Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Backport-to: 24.1 Backport-to: 24.2 Part-of: <!30818> (cherry picked from commit b1ba7d1b)
-
fossil-db (navi31): Totals from 9776 (12.31% of 79395) affected shaders: Instrs: 19348258 -> 19383680 (+0.18%); split: -0.00%, +0.19% CodeSize: 101223460 -> 101366964 (+0.14%); split: -0.01%, +0.15% Latency: 172853115 -> 172866070 (+0.01%); split: -0.01%, +0.01% InvThroughput: 27590468 -> 27592390 (+0.01%); split: -0.00%, +0.01% Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Closes: #11550 Closes: #11436 Closes: #11337 Gitlab: #11738 Closes: #11741 Backport-to: 24.1 Backport-to: 24.2 Part-of: <!30818> (cherry picked from commit 8f5ee70d)
-
LLVM ignores exec and literals don't seem to work in some cases. fossil-db (navi31): Totals from 2676 (3.37% of 79395) affected shaders: Instrs: 10638979 -> 10646019 (+0.07%); split: -0.00%, +0.07% CodeSize: 55929640 -> 55959416 (+0.05%); split: -0.00%, +0.06% Latency: 107707408 -> 107712893 (+0.01%); split: -0.00%, +0.01% InvThroughput: 18119843 -> 18120442 (+0.00%); split: -0.00%, +0.00% Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Daniel Schürmann <daniel@schuermann.dev> Backport-to: 24.1 Backport-to: 24.2 Part-of: <!30818> (cherry picked from commit ee648326)
-
Eric Engestrom authored
-
- Aug 22, 2024
-
-
The buffers can be reused, so we must only allocate added segments and free unused segments. Fixes: be4287c3 ("pipe: Extend get_feedback with additional metadata") Reviewed-By: Sil Vilerino <sivileri@microsoft.com> Part-of: <!30779> (cherry picked from commit 1ebff222)
-
At least one ray tracing shader in cp2077 is over 4MB on Xe2. There isn't a memory pool large enough for the allocation, so the driver crashes instead. This commit adds 8MB and 16MB pools. I intend this as a stop gap fix. I would prefer to figure out why this shader is so much larger than on previous platforms. The shader in question has 3824 spills and 8625 fills. That is not good. I suspect dealing with that will also solve the problem, but that will require a bit more time. Closes: #11739 Suggested-by: Lionel Landwerlin Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Cc: mesa-stable Part-of: <!30751> (cherry picked from commit 09cf9fe8)
-
Suggested-by: Paulo Zanoni Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com> Cc: mesa-stable Part-of: <!30751> (cherry picked from commit 0921dfa0)
-
this avoids a scenario where invalidate happens after a non-winsys blit for a renderpass and the driver skips storing framebuffer contents because the invalidate flag is set cc: mesa-stable Acked-by: Marek Olšák <marek.olsak@amd.com> Part-of: <!30750> (cherry picked from commit 2fa52bf6)
-
inlined resolve ops are still somehow slower than explicit ones, so the data has to be written out for the resolve cc: mesa-stable Acked-by: Dave Airlie <airlied@redhat.com> Part-of: <!30750> (cherry picked from commit 38f4501a)
-
Choosing the wrong instruction length prevents radv_dump_annotated_shader from matching waves. cc: mesa-stable Part-of: <mesa/mesa!30734> (cherry picked from commit 1cf507b8)
-