- May 27, 2020
-
-
Eric Engestrom authored
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
-
Eric Engestrom authored
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
-
Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Acked-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 8c6350d2)
-
Loosely based on ANV. Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Acked-by: Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 021270cb)
-
It was found that dual-source blending hangs with SIMD16 dispatch in some specific but unknown situation. Which in the wild happen when rgba anti-aliasing is enabled for fonts. Cc: <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#2183 Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Part-of: <mesa/mesa!5037> (cherry picked from commit 296c04d7)
-
This avoids a validator warning when for instance generating mipmaps. Fixes: d2bb63c8 ("zink: Use optimal layout instead of general. Reduces valid layer warnings. Fixes RADV image noise.") Reviewed-by: Mike Blumenkrantz <michael.blumenkrantz@gmail.com> Part-of: <mesa/mesa!5199> (cherry picked from commit dd2bd68f)
-
Currently the nir linker resizes the amount of storage needed to hold uniform information on the fly while linking. As shaders can contain thousands of uniforms this can be very slow. For example some Godot shaders can take 30 seconds to compile on some machines. In this change we count the amount of storage needed before we start processing the uniforms. This is what the GLSL IR linker does also. Fixes: 95f555a9 ("st/glsl_to_nir: make use of nir linker for linking uniforms") Closes: mesa/mesa#2996 Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> Part-of: <mesa/mesa!5137> (cherry picked from commit f1acf492)
-
Generally we do not completely stop compilation as soon as we see an error, instead we continue on to attemp to find any futher errors. This means we shouldn't be checking state->error to see if any error has happened during the compilation process, doing so was causing process_parameters() to fail on completely valid functions if there was any error found in the shader previously. This then caused the valid functions not to be found because the paramlist was considered empty, resulting in the compiler spewing out misleading error messages. Here we simply add the IR error value to the param list when we have an issue with processing a parameter, this leads to much better error messaging. Fixes: 53e4159e ("glsl: stop processing function parameters if error happened") Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!5205> (cherry picked from commit f6214750)
-
Fix warning reported by Coverity Scan. Missing varargs init or cleanup (VARARGS) missing_va_end: va_end was not called for ap. Fixes: a0ca1462 ("freedreno: add logging infrastructure") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Part-of: <mesa/mesa!5221> (cherry picked from commit 755c0400)
-
The resource tracking in the clear/draw_vbo/blit paths could itself trigger a flush. Which would update last_fence. So we need to clear last_fence *after* all the dependency tracking. Fixes: ddb7fada ("freedreno: avoid no-op flushes by re-using last-fence") Closes: mesa/mesa#2992 Signed-off-by: Rob Clark <robdclark@chromium.org> Part-of: <mesa/mesa!5188> (cherry picked from commit 8728c420)
-
Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Fixes: 18ed82b0 ('nir: Add a pass for selectively lowering variables to scratch space') Part-of: <mesa/mesa!5214> (cherry picked from commit 8e2009c4)
-
Fixes: 4422ce1b r600: force new CF with TEX only if any texture value is written Closes #3012 Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!5187> (cherry picked from commit 901793d5)
-
Fix warning reported by Coverity Scan. Useless call (USELESS_CALL) side_effect_free: Calling v->pin_to_channel() is only useful for its return value, which is ignored. Fixes: 5d10e3ec ("r600/nir: Pin interpolation results to channel") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!5197> (cherry picked from commit 1241f8cb)
-
This was implemented in version 6 of the VK_ANDROID_native_buffer extension and we only implement version 5. However, the Android Vulkan loader only checks whether vkGetInstanceProcAddr for the function is not NULL. This all went wrong when we switched to the layer code from ANV. Because the function may now be different per device, it adds fallback functions that dispatch to the dispatch table. So if we didn't implement the function we still returned a pointer to the dispatch function, which made the Android Vulkan loader believe it was supported. Dispatch functions: https://gitlab.freedesktop.org/mesa/mesa/-/blob/d555794f3032594dbef3623052103900138d2356/src/amd/vulkan/radv_entrypoints_gen.py#L328 Fixes: d555794f "radv: update entrypoints generation from ANV" Gitlab: mesa/mesa#2936 Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!5198> (cherry picked from commit be784cc7)
-
Fixes: cd6ec2b1 "radv: implement a dummy winsys for creating devices without AMDGPU" Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!5181> (cherry picked from commit a51ab5f9)
-
Fixes: f4e499ec "radv: add initial non-conformant radv vulkan driver" Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!5181> (cherry picked from commit cd61f523)
-
The pointer is already uint64_t*, so the sizeof was too much ... Fixes: eeff7e11 "radv: Add userspace fence buffer per context." Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Part-of: <mesa/mesa!5181> (cherry picked from commit 906435fb)
-
Fix warning reported by Coverity Scan. Uninitialized scalar field (UNINIT_CTOR) uninit_member: Non-static class member m_num_clip_dist is not initialized in this constructor nor in any functions that it calls. Fixes: f7df2c57 ("r600/sfn: extract class to handle the VS export to different stages") Signed-off-by: Vinson Lee <vlee@freedesktop.org> Reviewed-by: Gert Wollny <gert.wollny@collabora.com> Part-of: <mesa/mesa!5180> (cherry picked from commit 73c0f60d)
-
This fixes problems in a number of games, including SuperTuxKart, OpenMW and RVGL. v2: Use MALI_READS_ZS | 0x20 instead of MALI_WRITES_Z to match with the blob. Keep using 0x400 | 0x20 when depth is disabled. Closes: #2620 Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> (cherry picked from commit 0dd24b38) Part-of: <mesa/mesa!5193>
-
Eric Engestrom authored
They will stop working in the next GitLab release, so let's update them ASAP to make sure things are propagated to everyone by then. See: https://about.gitlab.com/releases/2020/05/06/gitlab-com-13-0-breaking-changes/#removal-of-deprecated-project-paths Cc: mesa-stable@lists.freedesktop.org Signed-off-by: Eric Engestrom <eric@engestrom.ch> Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <!5111> (cherry picked from commit 444138d6)
-
Part-of: <mesa/mesa!5176> (cherry picked from commit 5f365aff)
-
Part-of: <mesa/mesa!5150> (cherry picked from commit be71e2fd)
-
Fixes: 96c32d77 "nir/copy_prop_vars: handle load/store of vector..." Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!5170> (cherry picked from commit f0e075ce)
-
Fixes: a1c68851 "nir/opt_deref: Properly optimize ptr_as_array..." Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!5170> (cherry picked from commit db6d9cdf)
-
Fixes: d7d35a95 "nir/lower_doubles: Use the new NIR lowering..." Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!5170> (cherry picked from commit 111b0a66)
-
Fixes: 7534c536 Fixes: 8cfb3e4e Closes: mesa/mesa#3024 Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Part-of: <mesa/mesa!5160> (cherry picked from commit 40255831)
-
clang warning: result of comparison of constant 115 with expression of type 'const enum Dim' is always false Fixes: e3e704c7 ("amd/addrlib: Use enum instead of sparse chars to identify dimensions") Reviewed-by: Michel Dänzer <mdaenzer@redhat.com> Part-of: <mesa/mesa!5119> (cherry picked from commit dddd91ee)
-
Some classes use custom new operator which zeroes memory, however gcc does aggressive dead-store elimination which threats all writes to the memory before the constructor as "dead stores". For now we disable this optimization. The new operators in question are declared via: DECLARE_RZALLOC_CXX_OPERATORS DECLARE_LINEAR_ZALLOC_CXX_OPERATORS The issue was found with lto builds, however there is no guarantee that it didn't happen with ordinary ones. CC: <mesa-stable@lists.freedesktop.org> Closes: mesa/mesa#2977 Closes: mesa/mesa#1358 Signed-off-by: Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!5104> (cherry picked from commit 5500a2b7)
-
I got to benchmarking some vulkan compute benchmark and wondered why my CPUs weren't being saturated, helps if you actually wake up all the threads in the threadpool. Fixes: 1b24e3ba (llvmpipe: add compute threadpool + mutex) Reviewed-by: Roland Scheidegger <sroland@vmware.com> Part-of: <mesa/mesa!5138> (cherry picked from commit 22554e1f)
-
The commit helps to resolve GL_INVALID_OPERATION error returned during CTS test when Android format RGBX8888 fallback to RGBA8888 and then set color with glTexSubImage2D(format=GL_RGB). Fixes android.hardware.nativehardware.cts.AHardwareBufferNativeTests: #SingleLayer_ColorTest_GpuSampledImageCanBeSampled_R8G8B8X8_UNORM Cc: <mesa-stable@lists.freedesktop.org> Fixes: bf576772 ("dri_util: add driImageFormatToSizedInternalGLFormat function") Signed-off-by: Nataraj Deshpande <nataraj.deshpande@intel.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> Part-of: <mesa/mesa!5034> (cherry picked from commit 02a1f953)
-
Issue description from Matt's commit e7c376ad: "var_range_end(v, n) loops over the n components of variable number v and finds the maximum value, giving the last use of any component of v. Therefore it expects v to correspond to the variable associated with the .x channel of the VGRF. var_from_reg() however returns the variable for the first channel of the VGRF, post-swizzle. So, if the last register had a swizzle with y, z, or w in the swizzle component, we would read out of bounds. For any other register, we would read liveness information from the next register. The fix is to convert the src_reg to a dst_reg in order to call the dst_reg version of var_from_reg() that doesn't consider the swizzle." Closes: #3003 Fixes: 48dfb30f ('intel/compiler: Move all live interval analysis results into vec4_live_variables') Reviewed-by: Matt Turner <mattst88@gmail.com> Signed-off-by: Andrii Simiklit <asimiklit.work@gmail.com> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4941> (cherry picked from commit d1b74628)
-
An unknown issue is causing vs push constants to become corrupted during object-level preemption. For now, restrict to command buffer level preemption to avoid rendering corruption. Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Part-of: <mesa/mesa!5110> (cherry picked from commit 81201e46)
-
Eric Engestrom authored
-
- May 20, 2020
-
-
Eric Engestrom authored
Signed-off-by: Eric Engestrom <eric@engestrom.ch>
-
Meson 0.55.0 will set the MESON_EXE_WRAPPER environment variable to the joined version of that wrapper if it is needed. Our tests that take compiled targets as arguments can use that information to run cross built binaries, or if there isn't a wrapper and we get an ENOEXEC, we can skip the tests gracefully. We try to use mesonlib.split_args, which handles windows arguments better than python's builtin shlex module, but fall back to that if the meson module isn't available for some reason. Cc: 20.0 20.1 <mesa-stable@lists.freedesktop.org> Reviewed-by: Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!5103> (cherry picked from commit 55803224)
-
This tells Mesa to clamp vertex colours in the vertex shader. This improves rendering in a number of games such as Extreme Tux Racer and H-Craft Championships. Cc: 20.1 <mesa-stable@lists.freedesktop.org> Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> Part-of: <mesa/mesa!5075> (cherry picked from commit faf28b83)
-
Fixes dEQP-VK.graphicsfuzz.loops-ifs-continues-call with RADV. opt_if_loop_terminator can cause this optimization or opt_if_simplification to be run on the non-SSA code. Signed-off-by: Rhys Perry <pendingchaos02@gmail.com> Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> Fixes: 52c8bc01 ('nir: make opt_if_loop_terminator() less strict') Closes: mesa/mesa#2943 Part-of: <mesa/mesa!4757> (cherry picked from commit 50bead32)
-
On EGL 1.4, one had to check for the existence of EGL_EXT_platform_base before querying the eglGetPlatformDisplayEXT() and eglCreatePlatformWindowSurfaceEXT() symbols, to then use them if the EGL_EXT_platform_* extension for the given platform was exposed. Since EGL 1.5, the platform functionality was made core, which means we can obtain the symbols unconditionally, but we can't know the EGL version before having created a display, at which point we've already done a platform selection by passing an EGLNativeDisplay. The EGL_KHR_platform_* extensions thus are used by clients to know whether it's safe or not to dlsym() the EGL 1.5 symbols. This commit adds those extensions when the given platform is enabled. Acked-by: Alyssa Rosenzweig <alyssa@collabora.com> Reviewed-by: Eric Engestrom <eric@engestrom.ch> Part-of: <mesa/mesa!5052> (cherry picked from commit a3fb064e)
-
Fixes: f718ac62 r600/sfn: Add a basic nir shader backend Signed-off-by: Gert Wollny <gert.wollny@collabora.com> Reviewed-by: Reviewed-by: Dave Airlie <airlied@redhat.com> Part-of: <mesa/mesa!5085> (cherry picked from commit 32305c09)
-
This reverts commit e2a7436d. The corresponding LLVM changes were reverted. Closes: mesa/mesa#2983 Acked-by: Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by: Marek Olšák <marek.olsak@amd.com> Part-of: <mesa/mesa!5087> (cherry picked from commit 667126cc)
-