There was an error fetching the commit references. Please try again later.
anv: Allow MSAA resolve with different numbers of planes
The Vulkan spec for VK_KHR_depth_stencil_resolve allows a format mismatch between the primary attachment and the resolve attachment within certain limits. In particular, VUID-VkSubpassDescriptionDepthStencilResolve-pDepthStencilResolveAttachment-03181 If pDepthStencilResolveAttachment is not NULL and does not have the value VK_ATTACHMENT_UNUSED and VkFormat of pDepthStencilResolveAttachment has a depth component, then the VkFormat of pDepthStencilAttachment must have a depth component with the same number of bits and numerical type VUID-VkSubpassDescriptionDepthStencilResolve-pDepthStencilResolveAttachment-03182 If pDepthStencilResolveAttachment is not NULL and does not have the value VK_ATTACHMENT_UNUSED, and VkFormat of pDepthStencilResolveAttachment has a stencil component, then the VkFormat of pDepthStencilAttachment must have a stencil component with the same number of bits and numerical type So you can resolve from a depth/stencil format to a depth-only or stencil-only format so long as the number of bits matches. Unfortunately, this has never been tested because the CTS tests which purport to test this are broken and actually test with a destination combined depth/stencil format. Fixes: 5e4f9ea3 ("anv: Implement VK_KHR_depth_stencil_resolve") Reviewed-by:Ivan Briano <ivan.briano@intel.com> Part-of: <mesa/mesa!15333> (cherry picked from commit d65dbe80)
Loading
Please register or sign in to comment