Skip to content
Snippets Groups Projects
  1. Jan 13, 2021
  2. Dec 31, 2020
  3. Dec 30, 2020
  4. Dec 29, 2020
  5. Dec 23, 2020
  6. Dec 14, 2020
  7. Dec 09, 2020
    • Jan Alexander Steffens's avatar
      srt: Don't take object lock calling gst_srt_object_get_stats · 670eab65
      Jan Alexander Steffens authored and GStreamer Marge Bot's avatar GStreamer Marge Bot committed
      This function takes the sock lock. This can result in a deadlock when
      another thread holding the sock lock is trying to take the object lock.
      
      Thread A (Holds object lock, wants sock lock):
      
          #2  gst_srt_object_get_stats at gst-plugins-bad/ext/srt/gstsrtobject.c:1753
          #3  gst_srt_object_get_property_helper at gst-plugins-bad/ext/srt/gstsrtobject.c:409
          #4  gst_srt_sink_get_property at gst-plugins-bad/ext/srt/gstsrtsink.c:95
          #5  g_object_get_property from libgobject-2.0.so.0
      
      Thread B (Holds sock lock, wants object lock):
      
          #2  gst_element_post_message_default at gstreamer/gst/gstelement.c:2069
          #3  gst_element_post_message at gstreamer/gst/gstelement.c:2123
          #4  gst_element_message_full_with_details at gstreamer/gst/gstelement.c:2259
          #5  gst_element_message_full at gstreamer/gst/gstelement.c:2298
          #6  gst_srt_object_send_headers at gst-plugins-bad/ext/srt/gstsrtobject.c:1407
          #7  gst_srt_object_send_headers at gst-plugins-bad/ext/srt/gstsrtobject.c:1444
          #8  gst_srt_object_write_to_callers at gst-plugins-bad/ext/srt/gstsrtobject.c:1444
          #9  gst_srt_object_write at gst-plugins-bad/ext/srt/gstsrtobject.c:1598
          #10 gst_srt_sink_render at gst-plugins-bad/ext/srt/gstsrtsink.c:179
      
      Fixes d2d00e07.
      
      Part-of: <gstreamer/gst-plugins-bad!1863>
      670eab65
    • Matthew Waters's avatar
      rtmp2/connection: pass the parent cancellable down to the connection · 9ed8a4c3
      Matthew Waters authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      Otherwise, when rtpm2src cancels an inflight operation that has a queued
      message stored, then the rtmp connection operation is not stopped.
      
      If the cancellation occurs during rtmp connection start up, then
      rtpm2src does not have any way of accessing the connection object as it
      has not been returned yet.  As a result, rtpm2src will cancel, the
      connection will still be processing things and the
      GMainContext/GMainLoop associated with the outstanding operation will be
      destroyed.  All outstanding operations and the rtmpconnection object will
      therefore be leaked in this case.
      
      Fixes: gstreamer/gst-plugins-bad#1425
      Part-of: <gstreamer/gst-plugins-bad!1865>
      9ed8a4c3
  8. Dec 06, 2020
  9. Dec 05, 2020
  10. Dec 04, 2020
  11. Dec 02, 2020
  12. Nov 25, 2020
  13. Nov 23, 2020
  14. Nov 20, 2020
  15. Nov 18, 2020
  16. Nov 09, 2020
  17. Nov 05, 2020
  18. Nov 04, 2020
  19. Oct 31, 2020
  20. Oct 30, 2020
Loading