Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 27
    • Issues 27
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Mike Blumenkrantz
  • mesamesa
  • Merge requests
  • !6

zink: Utilize VK_USE_64_BIT_PTR_DEFINES for VkDescriptorSetLayout and VkFramebuffer handle storage

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Witold Baryluk requested to merge baryluk/mesa:baryluk-zink-wip-patch-96522 into zink-wip Apr 13, 2021
  • Overview 1
  • Commits 2
  • Pipelines 4
  • Changes 2

Vulkan 1.2.174 fixed the issue around the type handling, and now it can be addressed using a simpler standardized and overridable macro.

Now both 32-bit and 64-bit systems can be handled easier.

I added the fallback macro for pre-1.2.174, but it will be ignored on newer Vulkan, so if there are any new architectures, or other changes, it will pick them up automatically.

The macro definition and conditions are copied directly from the vulkan_core.h

For details see:

https://github.com/KhronosGroup/Vulkan-Docs/issues/1431 https://github.com/KhronosGroup/Vulkan-Headers/commit/e1d8c4931d8e4b6c4a8e633c163ed3aa82d6ac1c https://github.com/KhronosGroup/Vulkan-Headers/blob/master/include/vulkan/vulkan_core.h#L28

Edited Apr 13, 2021 by Witold Baryluk
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: baryluk-zink-wip-patch-96522