- Jan 17, 2019
-
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
-
- Jan 16, 2019
-
-
Tim-Philipp Müller authored
-
Tim-Philipp Müller authored
-
- Jan 14, 2019
-
-
Nirbheek Chauhan authored
When the audio device goes away during playback or capture, we were going into an infinite loop of AUDCLNT_E_DEVICE_INVALIDATED. Return -1 and post an error message so the ringbuffer thread exits with an error.
-
Jan Alexander Steffens authored
0a350c61 broke the build by only building enum types with meson. It also removed gstsrt.c from the list of sources, causing the plugin to fail to load. squash! srt: Fix autotools build
-
Jan Alexander Steffens authored
gstsrtobject.c: In function ‘gst_srt_object_close’: gstsrtobject.c:1036:7: error: function called through a non-compatible type [-Werror] (GDestroyNotify) g_closure_unref); /usr/include/glib-2.0/glib/gmem.h:121:8: note: in definition of macro ‘g_clear_pointer’ (destroy) (_ptr); \ ^~~~~~~ gstsrtobject.c:1038:7: error: function called through a non-compatible type [-Werror] (GDestroyNotify) g_closure_unref); /usr/include/glib-2.0/glib/gmem.h:121:8: note: in definition of macro ‘g_clear_pointer’ (destroy) (_ptr); \ ^~~~~~~ Arch Linux gcc 8.2.1 20181127 glib 2.58.2
-
- Jan 11, 2019
-
-
BRCParamMultiplier in mfxInfoMFX is a parameter which specifies a multiplier for bitrate control parameters [1], it impacts TargetKbps, MaxKbps, BufferSizeInKB and InitialDelayInKB. [1]: https://software.intel.com/en-us/node/628473
-
The upper bound of bitrate is also 2048000 kbps which should be large enough in practice. Fix gstreamer/gst-plugins-bad#863
-
- Jan 10, 2019
-
-
Nirbheek Chauhan authored
Variable name was typoed in 604c8d52
-
- Jan 09, 2019
-
-
We have srt{client,server}{src,sink} elements in accordance to the norm of the connection oriented protocols. However, SRT connection mode can be changed by uri parameters so it requires an integrated element to handle the parameters. fix: #740
-
Haihao Xiang authored
According to the MSDK documation[1], MFXCloneSession is a light-weight equivalent of MFXJoinSession after MFXInit, so MFXJoinSession call isn't needed in the msdk plugin, otherwise the cloned session is joined to the parent session twice, and we will get a MFX error when closing the parent session example pipeline: gst-launch-1.0 videotestsrc num-buffers=100 ! \ video/x-raw,format=NV12,width=352,height=288 ! msdkh264enc ! msdkh264dec ! \ msdkh264enc ! fakesink Error message: 0:00:00.211948518 21733 0x5586ee741c60 ERROR msdk msdk.c:148:msdk_close_session: Close failed (undefined behavior) [1]: https://software.intel.com/en-us/node/628429#MFXCloneSession
-
Haihao Xiang authored
And log the failures for debugging
-
Haihao Xiang authored
The returned type is a pointer
-
Haihao Xiang authored
Needn't check the pointers against NULL because the pointers are non-NULL
-
- Jan 08, 2019
-
-
Víctor Manuel Jáquez Leal authored
based on the patches provided by Haihao Xiang <haihao.xiang@intel.com>
-
Víctor Manuel Jáquez Leal authored
Thus removing the preprocessor's directives to included if found.
-
Víctor Manuel Jáquez Leal authored
Refactoring to bail out early if MediaSDK is not found. based on the patches provided by Haihao Xiang <haihao.xiang@intel.com>
-
Víctor Manuel Jáquez Leal authored
-
In gst-msdk, a mfx session may be shared between different gst elements, each element tries to set the frame allocator. However, per the MSDK documation[1], the behavior is undefined if reset the frame allocator while the previous allocator is in use. Fortunately all elements use the same frame allocator, so we can avoid to call MFXVideoCORE_SetFrameAllocator again. [1]: https://software.intel.com/en-us/node/628430#MFXVideoCORE3
-
Haihao Xiang authored
If so, BGRA is the preferred output format hence BGRA will be selected as input format by default, e.g. in the pipleline below, BGRA instead of NV12 is selected without renegotiation, so we can avoid the NV12 issue (see commit 3f2314a1) by default. gst-launch-1.0 videotestsrc ! msdkvpp ! glimagesink
-
Haihao Xiang authored
Otherwise MFXVideoVPP_Init will fail because it is called twice without a close. Example pipeline: gst-launch-1.0 videotestsrc ! msdkvpp ! glimagesink Sometimes glimagesink emits GST_EVENT_RECONFIGURE event which results in that MFXVideoVPP_Init is called twice, then get the negotiation failure below: 0:00:00.093715518 21218 0x558ef56231e0 ERROR msdkvpp gstmsdkvpp.c:995:gst_msdkvpp_initialize:<msdkvpp0> Init failed (undefined behavior) WARNING: from element /GstPipeline:pipeline0/GstMsdkVPP:msdkvpp0: not negotiated After applying this commit, the pipeline above may run without negotiation failure, however NV12 layout in dmabuf mode is selected in renegotiation, the display image is corrupted due to the NV12 issue which was mentioned in commit 3f2314a1. Some other fixes are needed to avoid renegotiation by default
-
Haihao Xiang authored
-
- Jan 07, 2019
-
-
U. Artie Eoff authored
In general, we should assume any unhandled error is non-recoverable. In the flush frames loop, some error states can cause us to never increment the task and therefore we get stuck in an infinite loop and generate GST_ELEMENT_ERROR over and over again. This eventually consumes all system memory and triggers OOM. Thus, assume the worst and break out of the loop upon the first "unhandled" error. gstreamer/gst-plugins-bad#859
-
- Jan 04, 2019
-
-
Nirbheek Chauhan authored
When either the source or sink goes from PLAYING -> NULL -> PLAYING, we call _reset() which sets client_needs_restart, and then we call prepare() which calls IAudioClient_Start(), so we don't need to call it again in src_read() or sink_write(). Unlike when we're just going PLAYING -> PAUSED -> PLAYING.
-
- Jan 03, 2019
-
-
It has to be symmetric with CoInitialize(), otherwise everything else will fail.
-
- Jan 02, 2019
-
-
Sebastian Dröge authored
And don't unref a clock that is potentially NULL.
-
- Dec 31, 2018
-
-
Tim-Philipp Müller authored
Fixes #857
-
- Dec 30, 2018
-
-
Seungha Yang authored
-
Seungha Yang authored
It's moved to -base and no more part of -bad
-
Seungha Yang authored
-
- Dec 28, 2018
-
-
Tim-Philipp Müller authored
Merged into the existing opengl plugin in -base.
-
- Dec 27, 2018
-
-
- Dec 26, 2018
-
-
- Dec 25, 2018
-
-
Tim-Philipp Müller authored
Fixes distcheck.
-
Tim-Philipp Müller authored
#457
-
Seungha Yang authored
void function cannot have return value gst-plugins-bad/sys/msdk/gstmsdkbufferpool.c(332): warning C4098: 'gst_msdk_buffer_pool_release_buffer': ...
-
- Dec 24, 2018
-
-
Justin Kim authored
OpenAL.framework doesn't provide 'alext.h'. Thus, openal is enabled only if the dependency is set by pkg-config. fixes: #852
-
- Dec 22, 2018
-
-
Philippe Normand authored
Bitrate was logged a second time instead of the max_bitrate.
-