Skip to content
Snippets Groups Projects
  1. Aug 26, 2024
  2. Aug 22, 2024
    • Mark Collins's avatar
      Disable ioctl signed overload for Bionic libc · f3f56f41
      Mark Collins authored
      
      Bionic libc ships with `ioctl` that has two signatures, one with an
      unsigned `request` parameter and one with a signed request parameter.
      
      This leads to compilation failing due to `__typeof__(ioctl)` being used
      by DRM which fails to resolve which overload to use, this has been fixed
      by defining `BIONIC_IOCTL_NO_SIGNEDNESS_OVERLOAD` on Android.
      
      Signed-off-by: default avatarMark Collins <mark@igalia.com>
      f3f56f41
  3. Aug 01, 2024
    • Su Hong Koo's avatar
      tests: Make modetest and proptest cc_binary in Android.bp · 88db6114
      Su Hong Koo authored
      
      Change module type of modetest and proptest from cc_test to cc_binary,
      as neither are tests.
      
      Signed-off-by: default avatarSu Hong Koo <sukoo@google.com>
      88db6114
    • Daniel Stone's avatar
      libs: Tie DSO minor versions to libdrm version · b0815faa
      Daniel Stone authored
      There is an excellent writeup explaining this requirement here:
          wayland/wayland#175
      
      
      
      In short, for mixed environments such as the Steam Runtime and other
      container-like environments, choosing which libdrm to link into the
      client's address space is a hard problem. If the runtime has a newer
      libdrm than the host, then it should be preferred, because the client
      may be using newly-added symbols. But if the host has a newer libdrm,
      then that should be used, because drivers may be depending on those.
      
      Bumping the DSO minor version is transparent to all users because apps
      only link against the major version, e.g. DT_NEEDED libdrm.so.2; the
      fact that libdrm.so.2 is a link to libdrm.so.2.122.0 is a detail known
      only to the loader, but it does let a smart runtime make better
      decisions.
      
      Signed-off-by: default avatarDaniel Stone <daniels@collabora.com>
      b0815faa
  4. Jul 30, 2024
    • Jiyong Park's avatar
      Enable GPU in crosvm · 4bd09d78
      Jiyong Park authored and Su Hong Koo's avatar Su Hong Koo committed
      When the GPU feature is turned on in crosvm, these modules are added as
      dependencies. Since crosvm is included in the virt APEX, add the APEX to
      the apex_available properties of the modules to make them available in
      the APEX.
      4bd09d78
    • Jiyong Park's avatar
      add crosvm to com.android.virt · d9043a25
      Jiyong Park authored and Su Hong Koo's avatar Su Hong Koo committed
      To do so, crosvm and its dependencies have the apex_available property
      set to "//apex_available:platform", "com.android.virt" to explicitly
      acknowledge the joining.
      d9043a25
    • Jason Macnak's avatar
      Adds libdrm_headers · f22956a4
      Jason Macnak authored and Su Hong Koo's avatar Su Hong Koo committed
      ... as being able to use cc_library in header_libs is not
      intended and does not work on all branches which blocks
      aosp/1497292.
      f22956a4
    • Inseob Kim's avatar
      Export include dirs with -isystem · 460f7907
      Inseob Kim authored and Su Hong Koo's avatar Su Hong Koo committed
      drm_property_type_is function in xf86drmMode.h file can cause compiler
      error because it performs unsigned to signed conversion. Some Android.mk
      modules have been avoiding this by adding "-isystem external/libdrm"
      flag, because warnings from system headers are suppressed.
      
      This changes exported_include_dirs to export_system_include_dirs
      to workaround the potential error with the same manner above.
      460f7907
    • Jason Macnak's avatar
      Makes libdrm available on host · dcb14fe0
      Jason Macnak authored and Su Hong Koo's avatar Su Hong Koo committed
      ... to make drm format header visible for host wayland server.
      
      Adds -Wno-implicit-function-declaration for vasprintf() on
      xf86drm.c:2965.
      
      Adds -Wno-int-conversion for drm_mmap() on libdrm_macros.h:60.
      
      Also, drive-by alphabetize cflags.
      dcb14fe0
    • Jerry Zhang's avatar
      Make libdrm recovery_available · 6aa6411c
      Jerry Zhang authored and Su Hong Koo's avatar Su Hong Koo committed
      6aa6411c
    • John Stultz's avatar
      Android.bp: Add include exports for android dir · c2b5759a
      John Stultz authored and Su Hong Koo's avatar Su Hong Koo committed
      This forward ports Stefan Schake's patch
      32ee9c0e "android: Add missing include exports" to the
      Android.bp file.
      c2b5759a
    • Elliott Hughes's avatar
      readdir_r is deprecated. · aef24b66
      Elliott Hughes authored and Su Hong Koo's avatar Su Hong Koo committed
      Add -Wno-deprecated-declarations to suppress compiler warning about
      using readdir_r, which is deprecated.
      aef24b66
    • Su Hong Koo's avatar
      Delete all Makefile.sources files · aefb5fa9
      Su Hong Koo authored
      Delete all Makefile.sources as all the makefiles that use them have
      been replaced with Android.*.bp files for Soong.
      aefb5fa9
  5. Jul 29, 2024
    • Dan Willemsen's avatar
      Convert to Android.bp · 21ac1816
      Dan Willemsen authored and Su Hong Koo's avatar Su Hong Koo committed
      See build/soong/README.md for more information about Soong.
      
      Removes BOARD_GPU_DRIVERS, which wasn't affecting anything, since none
      of the HAVE_* macros are defined. Even if they were, we'd prefer to
      compile all of them so that a single library can support multiple
      boards.
      21ac1816
  6. Jul 12, 2024
  7. Jun 27, 2024
  8. Jun 26, 2024
  9. Jun 25, 2024
  10. Jun 24, 2024
  11. Jun 02, 2024
  12. Jun 01, 2024
  13. May 27, 2024
  14. May 23, 2024
    • José Expósito's avatar
      amdgpu: Make amdgpu_cs_signal_semaphore() thread-safe · 4df91735
      José Expósito authored and Pierre-Eric Pelloux-Prayer's avatar Pierre-Eric Pelloux-Prayer committed
      
      The issue was found by a static analysis tool:
      
          Error: LOCK_EVASION (CWE-543):
          libdrm-2.4.115/amdgpu/amdgpu_cs.c:596: thread1_checks_field:
              Thread1 uses the value read from field "context" in the
              condition "sem->signal_fence.context". It sees that the
              condition is false. Control is switched to Thread2.
          libdrm-2.4.115/amdgpu/amdgpu_cs.c:596: thread2_checks_field:
              Thread2 uses the value read from field "context" in the
              condition "sem->signal_fence.context". It sees that the
              condition is false.
          libdrm-2.4.115/amdgpu/amdgpu_cs.c:598: thread2_acquires_lock:
              Thread2 acquires lock "amdgpu_context.sequence_mutex".
          libdrm-2.4.115/amdgpu/amdgpu_cs.c:599: thread2_modifies_field:
              Thread2 sets "context" to a new value. Note that this write can
              be reordered at runtime to occur before instructions that do
              not access this field within this locked region. After Thread2
              leaves the critical section, control is switched back to
              Thread1.
          libdrm-2.4.115/amdgpu/amdgpu_cs.c:598: thread1_acquires_lock:
              Thread1 acquires lock "amdgpu_context.sequence_mutex".
          libdrm-2.4.115/amdgpu/amdgpu_cs.c:599: thread1_overwrites_value_in_field:
              Thread1 sets "context" to a new value. Now the two threads have
              an inconsistent view of "context" and updates to fields of
              "context" or fields correlated with "context" may be lost.
          libdrm-2.4.115/amdgpu/amdgpu_cs.c:596: use_same_locks_for_read_and_modify:
              Guard the modification of "context" and the read used to decide
              whether to modify "context" with the same set of locks.
          #  597|                   return -EINVAL;
          #  598|           pthread_mutex_lock(&ctx->sequence_mutex);
          #  599|->         sem->signal_fence.context = ctx;
          #  600|           sem->signal_fence.ip_type = ip_type;
          #  601|           sem->signal_fence.ip_instance = ip_instance;
      
      Check `sem->signal_fence.context` in the locked region to avoid a race
      condition.
      
      Reviewed-by: default avatarPierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com>
      Signed-off-by: default avatarJosé Expósito <jexposit@redhat.com>
      4df91735
  15. Apr 11, 2024
  16. Apr 10, 2024
  17. Mar 29, 2024
  18. Mar 27, 2024
  19. Mar 25, 2024
Loading