Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 934
    • Issues 934
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 121
    • Merge requests 121
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

Update #1:

Due to abusive users subverting our CI facilities to mine cryptocurrency, breaking out of the container sandbox in the process, we have been forced to take actions to limit the usage of the public runners to official projects only.

The policy will be enforced on 2023-03-23 (or before if we detect abuses).

Please see this issue for more context and to see if and how you are impacted.

  • xorgxorg
  • xserverxserver
  • Merge requests
  • !977

xwayland: Delay wl_surface destruction

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Olivier Fourdan requested to merge ofourdan/xserver:xwayland-mitigate-wl_surface-id-race into master Sep 23, 2022
  • Overview 28
  • Commits 1
  • Pipelines 5
  • Changes 4

X11 and Wayland requests are unordered, causing a race in the X11 window and wl_surface association.

To mitigate that race, delay the wl_surface destruction by 1 second, so that the X11 DestroyNotify can be processed by the X11 window manager before the Wayland object ID gets reused.

This is only a mitigation though, a more robust solution requires a future dedicated Wayland protocol.

Closes: #1157 (closed)
Signed-off-by: Olivier Fourdan ofourdan@redhat.com
Suggested-by: Pekka Paalanen pekka.paalanen@collabora.com
See-also: wayland/wayland-protocols!163 (merged)

\cc: @pq @JoshuaAshton

Note: This is a stop gap solution which is meant to be backported to the current stable releases - I expect this mechanism to be superseded by the new Wayland protocol from wayland/wayland-protocols!163 (merged) in the next major release of Xwayland for the compositors that support it.

Note 2: This is untested.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: xwayland-mitigate-wl_surface-id-race