Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 887
    • Issues 887
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 113
    • Merge requests 113
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • xserverxserver
  • Merge requests
  • !934

xwayland: fix glamor es black windows

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Konstantin requested to merge rilian-la-te/xserver:xwayland-fix-black-windows-es into master Jul 04, 2022
  • Overview 24
  • Commits 1
  • Pipelines 5
  • Changes 2

On some drivers (mesa included), when we request GBM_FORMAT_XRGB8888, driver set surface storage format to GL_RGB8, which breaks gles2 rendering. If we force set gbm_format to GBM_FORMAT_ARGB8888, then rendering will happen and working. For correct colors, we need !924.

This is a screenshot of XWayland VirtualBox with !924 and !934 and MESA_GL_VERSION_OVERRIDE=2.0 and MESA_GLES_VERSION_OVERRIDE=2.0

glamor_es_fixe

Without !924, I will get incorrect colors (#1354), and without !934, I will get black window (#1356).

Fixes #1288 Fixes #1356

Request for review: @ofourdan @ajax @anholt

Edited Jul 10, 2022 by Konstantin
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: xwayland-fix-black-windows-es