Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 887
    • Issues 887
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 112
    • Merge requests 112
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • xserverxserver
  • Merge requests
  • !888

x86emu: re-align breaks in ins() and outs()

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Alan Coopersmith requested to merge alanc/xserver:x86emu into master Mar 29, 2022
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 1

Makes the 4-byte cases match those for 1- & 2-byte handling, moving the break from being unconditionally hit the first time through the to loop to after the loop is done.

Fixes Solaris Studio compiler warnings:

"prim_ops.c", line 2626: warning: end-of-loop code not reached
"prim_ops.c", line 2692: warning: end-of-loop code not reached

I found this when resyncing a copy of the x86emu code in Solaris that is used in our vbiosd for configuring a text console on the graphics output with the latest Xorg sources. I have no test case for this, but it looks correct and matches the other cases, and it's been in use in our vbiosd since 2019.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: x86emu