Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 942
    • Issues 942
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 124
    • Merge requests 124
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !885

[Backport to Xwayland-22.1] xwayland: Always hook up frame_callback_list in xwl_present_queue_vblank

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Olivier Fourdan requested to merge ofourdan/xserver:backport-xwayland-22.1-frame_callback_list-fix into xwayland-22.1 Mar 24, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 3

Even if there's no pending frame callback yet.

Without this, if there was no pending frame callback yet in xwl_present_queue_vblank, xwl_present_msc_bump would only get called from xwl_present_timer_callback, resulting in the MSC ticking at ~58 Hertz.

Doing this requires some adjustments elsewhere:

  1. xwl_present_reset_timer needs to check for a pending frame callback as well.
  2. xwl_window_create_frame_callback needs to call xwl_present_reset_timer for all child windows hooked up to frame_callback_list, to make sure the timer length takes the pending frame callback into account.
  3. xwl_present_flip needs to hook up the window to frame_callback_list before calling xwl_window_create_frame_callback, for 2. to work.

Closes: #1309 (closed) Fixes: 9b31358c ("xwayland: Use frame callbacks for Present vblank events") Reviewed-by: Olivier Fourdan ofourdan@redhat.com (cherry picked from commit 9e5a3796)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: backport-xwayland-22.1-frame_callback_list-fix