Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 885
    • Issues 885
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • xserverxserver
  • Merge requests
  • !871

[Backport to xwayland-22.1] xwayland: Fix cursor color

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Olivier Fourdan requested to merge ofourdan/xserver:xwayland-22.1-cursor-wrong-colors into xwayland-22.1 Feb 11, 2022
  • Overview 0
  • Commits 1
  • Pipelines 1
  • Changes 1

When using colored X11 cursors, the colors would appear wrong, yellow would show white, green would show as cyan, and blue would show black whereas red would show fine.

This is because the code expanding the cursor data accounts for green for both green and blue channels. Funnily this bug has been there from the beginning.

Fix the issue by correctly account for the color channels.

Closes: #1303 (closed) Signed-off-by: Olivier Fourdan ofourdan@redhat.com Reviewed-by: Simon Ser contact@emersion.fr Reviewed-by: Michel Dänzer mdaenzer@redhat.com (cherry picked from commit 6ad6517a)

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: xwayland-22.1-cursor-wrong-colors