Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 887
    • Issues 887
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 111
    • Merge requests 111
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • xserverxserver
  • Merge requests
  • !648

config: Fix platform busid parsing when there is no ID_PATH prop

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Povilas Kanapickas requested to merge p12tic/xserver:fix-platform-busid-udev-no-id-path into master Apr 07, 2021
  • Overview 6
  • Commits 1
  • Pipelines 3
  • Changes 1

On at least Lenovo Thinkpad E585 udev does not have ID_PATH property for the drm node (see #993 (closed)). While this is likely udev bug, this causes the device to be not recognized as attribs->busid is NULL, which causes platform_find_pci_info to be not called and corresponding xf86_platform_devices[i]->pdev to be NULL.

At this moment pdev being NULL will cause a crash, but this is a different bug.

Fixes: #993 (closed)

Fixes: 0816e8fc linux: Make platform device probe less fragile

Edited Apr 13, 2021 by Povilas Kanapickas
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-platform-busid-udev-no-id-path