Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 885
    • Issues 885
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 102
    • Merge requests 102
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • xserverxserver
  • Merge requests
  • !583

xi: Fix touch ownership handling during grabs

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Povilas Kanapickas requested to merge p12tic/xserver:fix-touch-ownership into master Dec 19, 2020
  • Overview 2
  • Commits 2
  • Pipelines 3
  • Changes 1

98e3db2a broke XI_TouchOwnership handling during active pointer grabs. The clients that selected XI_TouchOwnership should get other touch events too, but right now we don't send any.

The fix is to limit the grab check only to the emulated events themselves, as that's what creates the crash 98e3db2a attempted to fix.

This MR fixes the following tests from xorg-integration-tests:

  • TouchOwnershipTest.ActivateGrabOwnershipAcceptTouch
  • TouchOwnershipTest.ActivateGrabOwnershipRejectTouch
  • TouchOwnershipTest.ActivateGrabOwnershipUngrabDevice
  • TouchGrabTest.DeviceGrabDeactivationReplayEmulatedEvents (new test that reproduces the exact crash that was fixed by 98e3db2a). This test has been added in xorg/test/xorg-integration-tests!13 (merged).

cc @whot

Edited Dec 20, 2020 by Povilas Kanapickas
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-touch-ownership