Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 944
    • Issues 944
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 123
    • Merge requests 123
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !521

glamor/streams: Drop the separate refcount for the xwl_pixmap

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Adam Jackson requested to merge ajax/xserver:xwayland-no-xwlpixmap-refcount into master Sep 22, 2020
  • Overview 5
  • Commits 1
  • Pipelines 2
  • Changes 1

Instead, bump the pixmap's refcount at the bottom of post_damage to reflect the compositor's hold on the buffer, and "destroy" the pixmap in the buffer release callback (which will dec the pixmap's refcount and free if necessary).


cc @ofourdan

Inspired by !520 (closed), but unlike !520 (closed) this mostly fixes the memory leak for me. I'm not completely convinced it's leak-free in the SetWindowPixmap path, but at least I'm no longer leaking one stream per resize event.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: xwayland-no-xwlpixmap-refcount