Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
xserver
xserver
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 890
    • Issues 890
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 96
    • Merge Requests 96
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • xserverxserver
  • Merge Requests
  • !484

Merged
Opened Jul 24, 2020 by Michel Dänzer@daenzerMaintainer

glamor: Fix glamor_poly_fill_rect_gl xRectangle::width/height handling

  • Overview 6
  • Commits 1
  • Pipelines 3
  • Changes 1

(Using GLSL 1.30 or newer)

The width/height members of xRectangle are unsigned, but they were being interpreted as signed when converting to floating point for the vertex shader, producing incorrect drawing for values > 32767.

Solve this by passing through the values as integers, and masking off the upper 16 bits in the vertex shader (which could be 1 due to sign extension).

Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: xorg/xserver!484
Source branch: glamor_poly_fill_rect_gl-width-height-unsigned