Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 884
    • Issues 884
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 101
    • Merge requests 101
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • xserverxserver
  • Merge requests
  • !482

xwayland: Hold a pixmap reference in struct xwl_present_event

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michel Dänzer requested to merge daenzer/xserver:xwl_present_event-pixmap-reference into server-1.20-branch Jul 22, 2020
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 2

In the log of the commit below, I claimed this wasn't necessary on the 1.20 branch, but this turned out to be wrong: It meant that event->buffer could already be destroyed in xwl_present_free_event, resulting in use-after-free and likely a crash.

Fixes: 22c0808a "xwayland: Free all remaining events in xwl_present_cleanup"

/cc @lyudess @ofourdan

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: xwl_present_event-pixmap-reference