Skip to content

GitLab

  • Menu
Projects Groups Snippets
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 887
    • Issues 887
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 109
    • Merge requests 109
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • xserverxserver
  • Merge requests
  • !45

Fix use after free on CRTC removal

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Olivier Fourdan requested to merge ofourdan/xserver:bug108249 into master Oct 18, 2018
  • Overview 5
  • Commits 2
  • Pipelines 6
  • Changes 2

I reckon https://bugs.freedesktop.org/show_bug.cgi?id=108249 ("[xwayland] Crash in Xpresent code on resume from suspend") is caused by the present code using a RRCrtcPtr previously freed by Xwayland.

Reason for this is because Xwayland's xwl_output_remove() will destroy the RRCrtcPtr for the Wayland outputs when removed, but if there is a flip pending, the xwl_present_sync_callback() will trigger after the CRTC is destroyed and not much good will come out of this.

Edited Oct 22, 2018 by Olivier Fourdan
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bug108249