Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 934
    • Issues 934
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 121
    • Merge requests 121
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

Update #1:

Due to abusive users subverting our CI facilities to mine cryptocurrency, breaking out of the container sandbox in the process, we have been forced to take actions to limit the usage of the public runners to official projects only.

The policy will be enforced on 2023-03-23 (or before if we detect abuses).

Please see this issue for more context and to see if and how you are impacted.

  • xorgxorg
  • xserverxserver
  • Merge requests
  • !429

Backport to 1.20 - xwayland: Fix infinite loop at startup

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Olivier Fourdan requested to merge ofourdan/xserver:display-roundtrip-loop-1.20-branch into server-1.20-branch Apr 27, 2020
  • Overview 0
  • Commits 1
  • Pipelines 2
  • Changes 3

Mutter recently added headless tests, and when running those tests the Wayland compositor runs for a very short time.

Xwayland is spawned by the Wayland compositor and upon startup will query the various Wayland protocol supported by the compositor.

To do so, it will do a roundtrip to the Wayland server waiting for events it expects.

If the Wayland compositor terminates before Xwayland has got the replies it expects, it will loop indefinitely calling wl_display_roundtrip() continuously.

To avoid that issue, add a new xwl_screen_roundtrip() that checks for the returned value from wl_display_roundtrip() and fails if it is negative.

Signed-off-by: Olivier Fourdan ofourdan@redhat.com Reviewed-by: Roman Gilg subdiff@gmail.com Reviewed-by: Jonas Ådahl jadahl@gmail.com

(cherry picked from commit 785e5906)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: display-roundtrip-loop-1.20-branch