Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
xserver
xserver
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 890
    • Issues 890
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 96
    • Merge Requests 96
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • xserverxserver
  • Merge Requests
  • !419

Closed
Opened Apr 07, 2020 by Adam Jackson@ajax💣Owner
  • Report abuse
Report abuse

shm: Fix arguments to PutImage on the XY conversion path

  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

The w/h here should be the w/h of the destination rectangle, not of the source shm image. The existing code happens to work because clipping saves us later, but this turns out to have enough performance impact that shmputxy is only barely faster than protocol putxy without the fix, even for Xvfb:

      before     after
   --------- ------------------   -----------------------------
    128000.0  128000.0 ( 1.000)   PutImage XY 10x10 square
      2120.0    2110.0 ( 0.995)   PutImage XY 100x100 square
        88.2      88.1 ( 0.999)   PutImage XY 500x500 square
    142000.0 1270000.0 ( 8.944)   ShmPutImage XY 10x10 square
      2250.0   90600.0 (40.267)   ShmPutImage XY 100x100 square
        89.6     109.0 ( 1.217)   ShmPutImage XY 500x500 square
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: xorg/xserver!419
Source branch: fix-shm-putimage-xy