Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 922
    • Issues 922
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 120
    • Merge requests 120
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !303

Call SourceValidate before GetImage

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Adam Jackson requested to merge ajax/xserver:getimage-validate into master Oct 09, 2019
  • Overview 8
  • Commits 4
  • Pipelines 5
  • Changes 19

This is a slightly cleaner approach to fixing #902 (closed). Recognizing that the GetImage and SourceValidate wrappers in composite and misprite are basically identical, we can eliminate the wrapping around GetImage if we make sure to call SourceValidate consistently. The only "sourcing" operations where we're not doing so are GetImage protocol requests, and the software indirect GLX path for glReadPixels etc. The latter already builds the entire reply after the GetImage operation, but the former need some adjustment to validate everything before the GetImage calls (particularly finicky in Xinerama).

Having done that, we can delete the wrappers in composite and misprite. Yay.

I still really dislike the way rotation and prime are nerfing the software cursor code in order to get the cursor image copied. I might like to fix that too, but that can be a follow-up change, and at any rate this should work equivalently.

 19 files changed, 60 insertions(+), 166 deletions(-)
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: getimage-validate