Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 923
    • Issues 923
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 128
    • Merge requests 128
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !291

miext/sync: Make struct _SyncObject::initialized fully ABI compatible

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Michel Dänzer requested to merge daenzer/xserver:server-1.20-branch into server-1.20-branch Sep 26, 2019
  • Overview 1
  • Commits 1
  • Pipelines 1
  • Changes 1

With a 32-bit build, putting the initialized field at the end of the struct bumped the struct size from 20 bytes to 24, changing the layout of other structs embedding struct _SyncObject. While this would be acceptable on master, it caused crashes with 1.20.

Making the initialized field a char and putting it in the hole before the beingDestroyed field restores the 32-bit ABI as well.

Fixes #892 (closed)

Reviewed-by: Aaron Plattner aplattner@nvidia.com Reviewed-by: Alex Goins agoins@nvidia.com (cherry picked from commit 0d8cc7bb)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: server-1.20-branch