Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 922
    • Issues 922
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 120
    • Merge requests 120
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !287

miext/sync: Fix ABI change on 32bit

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Olivier Fourdan requested to merge ofourdan/xserver:issue892 into master Sep 23, 2019
  • Overview 3
  • Commits 1
  • Pipelines 1
  • Changes 1

The newly added field initialized increases the size of the structure _SyncObject on 32bit, which is embedded in other structures, and therefore can cause a crash of the Xserver when a client tries to create a fence.

To avoid changing the size of the structure, and therefore breaking the ABI, move the field back where it was initially but change its type to a 1 byte char instead of Bool which is defined as an integer.

Closes: #892 (closed) Fixes: 8449c862 miext/sync: Fix needless ABI change Suggested-by: Michel Dänzer mdaenzer@redhat.com Signed-off-by: Olivier Fourdan ofourdan@redhat.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue892