Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 944
    • Issues 944
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 123
    • Merge requests 123
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !241

xfree86: always call KDSKBMODE on vt enter with logind

  • Review changes

  • Download
  • Patches
  • Plain diff
Closed Peter Hutterer requested to merge whot/xserver:wip/keycode-leak into master Jul 23, 2019
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 3

Where we're running with systemd-logind integration we have to assume that logind may change the KDSKBMODE while we're VT-switched away. If that happens and we return, our keyboard input may leak to the console.

Fix this by always calling K_OFF/K_RAW on VT switch back. We don't update the current settings though, so on shutdown we will restore to settings we had on init. Given the assumption is that if something messes with our vt, it will mess again anyway, it's not worth the bother.

Fixes #857

Warning: I couldn't reproduce the original issue, so I'm not sure whether this works. I'll need someone who was affected by this issue to actually test this and report back.

cc @ajax because he knows this code, or at least knew it many moons ago

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: wip/keycode-leak