Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 923
    • Issues 923
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 129
    • Merge requests 129
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !229

dix: Do not send events in keyboard/pointer grab if old and new window are the same.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open J-Bu requested to merge J-Bu/xserver:master into master Jul 15, 2019
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

This fixes a bug in Citrix Workspace App when TransparentKeyPassthrough=Remote is set in wfclient.ini and the session is in window mode. I assume Citrix Workspace App sends a GrabKeyboard although it already has the keyboard grabbed and in it's focus out/in events ungrabs/grabs the keyboard again. This leads to an endless loop where the Citrix Workspace App toggles grab/ungrab ob keyboard and this makes the xserver unresponsive and cpu usage on one core goes to 100%

The fix from 364d6498 did not work here because grabinfo->grab was NULL

Edited Aug 01, 2019 by J-Bu
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master