Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 923
    • Issues 923
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 128
    • Merge requests 128
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !193

glamor: Make pixmap exportable from `gbm_bo_from_pixmap()`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Olivier Fourdan requested to merge ofourdan/xserver:issue68 into master May 07, 2019
  • Overview 2
  • Commits 1
  • Pipelines 3
  • Changes 1

If a pixmap is not exportable, glamor_gbm_bo_from_pixmap() would fail and the modesettings driver would consequently fail to do its page flip, which both prevents Present from working and also fill up the logs with error messages such as:

(EE) modeset(0): Failed to get GBM bo for flip to new front. (EE) modeset(0): present flip failed

Refactor the code so that glamor_gbm_bo_from_pixmap() takes care of making the pixmap exportable.

Signed-off-by: Olivier Fourdan ofourdan@redhat.com Signed-off-by: Yuxuan Shui yshui@hadean.com See-also: !131 (closed) Closes: #68 (closed) Fixes: 86b2d874 "glamor: Reallocate pixmap storage without modifiers if necessary"

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue68