glamor: use gbm_format_for_depth, x11/xwayland: enable 30-bit pixmaps
The goal is to fix piglit glx-visuals-depth -pixmap
and glx-visuals-stencil -pixmap
tests.
The first commit is required to support all possible depth formats received.
The second commit, is to fix this error:
glXGetFBConfigAttrib(dpy, config, GLX_FBCONFIG_ID, &id);
fprintf(stderr, "fbconfig %d has GLX_PIXMAP_BIT but there "
"is no pixmap format for depth %d, this "
"is a server bug\n", id, depth);
that appears when XListDepths
and glXGetFBConfigs
disagrees on 30-bit support.
Merge request reports
Activity
mentioned in merge request mesa/piglit!983 (merged)
mentioned in merge request mesa/mesa!33036 (merged)
- Resolved by Pierre-Eric Pelloux-Prayer
- Resolved by Michel Dänzer
4dd0c404 should be split into two commits, one each for Xwayland & Xorg. (Can the Xorg driver do this? There's no clear path to a new major xserver release anytime soon)
- Resolved by Pierre-Eric Pelloux-Prayer
- Resolved by Pierre-Eric Pelloux-Prayer
- Resolved by Pierre-Eric Pelloux-Prayer
The second commit, is to fix this error:
The error requires that Mesa exposes 10 bpc configs with
GLX_PIXMAP_BIT
, even if the server doesn't support depth 30 pixmaps. That seems like a separate bug which should be fixed in Mesa as well.
- Resolved by Pierre-Eric Pelloux-Prayer
- Resolved by Michel Dänzer
- Resolved by Michel Dänzer
- Resolved by Pierre-Eric Pelloux-Prayer
The shortlog of 12c36822 still talks about
GLX_PIXMAP_BIT
.Other than that, this looks good to me.
added 1 commit
- 8331865e - glamor: reject configs using unsupported rgbBits size
- Resolved by Michel Dänzer
Can you attach the output of
glxinfo
with and without this MR?
added glamor label
assigned to @marge-bot