glamor: use gbm_format_for_depth, x11/xwayland: enable 30-bit pixmaps

The goal is to fix piglit glx-visuals-depth -pixmap and glx-visuals-stencil -pixmap tests.

The first commit is required to support all possible depth formats received.

The second commit, is to fix this error:

                    glXGetFBConfigAttrib(dpy, config, GLX_FBCONFIG_ID, &id);
                    fprintf(stderr, "fbconfig %d has GLX_PIXMAP_BIT but there "
                                    "is no pixmap format for depth %d, this "
                                    "is a server bug\n", id, depth);

that appears when XListDepths and glXGetFBConfigs disagrees on 30-bit support.

mentioned in merge request mesa/piglit!983 (merged)

mentioned in merge request mesa/mesa!33036 (merged)

added 2 commits

• dcdae40b - glamor: use gbm_format_for_depth instead of open-coding it
• 4dd0c404 - Support 30-bit pixmaps

Compare with previous version

resolved all threads

4dd0c404 should be split into two commits, one each for Xwayland & Xorg. (Can the Xorg driver do this? There's no clear path to a new major xserver release anytime soon)

The second commit, is to fix this error:

The error requires that Mesa exposes 10 bpc configs with GLX_PIXMAP_BIT, even if the server doesn't support depth 30 pixmaps. That seems like a separate bug which should be fixed in Mesa as well.

added 3 commits

• 427fe878 - glamor: return the result of gbm_format_for_depth
• bc4c62f9 - glamor: use gbm_format_for_depth instead of open-coding it
• 54fd03ef - glamor: set GLX_PIXMAP_BIT for supported depth values

Compare with previous version

added 3 commits

• 04eda1c3 - glamor: return the result of gbm_format_for_depth
• 0f8ead05 - glamor: use gbm_format_for_depth instead of open-coding it
• 12c36822 - glamor: set GLX_PIXMAP_BIT for supported depth values

Compare with previous version

The shortlog of 12c36822 still talks about GLX_PIXMAP_BIT.

Other than that, this looks good to me.

added 1 commit

• 8331865e - glamor: reject configs using unsupported rgbBits size

Compare with previous version

resolved all threads

Can you attach the output of glxinfo with and without this MR?

added glamor label

assigned to @marge-bot