Skip to content

xwayland: Do not keep the cursor's pixmap around

Olivier Fourdan requested to merge ofourdan/xserver:xwayland-cursor-drop-shm-pixmap-reference into master

Currently, Xwayland creates a pixmap backed by shared memory buffer as soon as an X11 cursor is realized, which is destroyed when the cursor is eventually unrealized.

If an X11 client is leaking cursors, Xwayland will be creating new pixmaps continuously, which will eventually cause an error once the limit is reached, and get Xwayland killed.

However, we do not need the shared memory buffer to stay around, we already have the buffer retention mechanism which will take care of keeping the buffer around until the Wayland compositor is done with it, so we could just create and destroy the pixmap as needed when setting the cursor.

That would not fix the leak in the X11 application, yet that would mitigate the risk of Xwayland being killed by reaching the shared memory limits, until the client itself reaches the limit of X11 resources.

Signed-off-by: Olivier Fourdan ofourdan@redhat.com
Suggested-by: Michel Dänzer michel@daenzer.net
See-also: #1773 (closed)

Edited by Olivier Fourdan

Merge request reports