Skip to content

hw/xfree86: Fix xf86sbusBus.c warnings and compilation failure

Matt Turner requested to merge mattst88/xserver:fix-sbus into master

  • hw/xfree86: Fix -Wmissing-prototypes warnings

    None of these functions are used elsewhere in the Xserver nor in any of the xf86-video-sun* DDXs.

  • hw/xfree86: Fix -Wincompatible-pointer-types sbus compile failure

    ../hw/xfree86/common/xf86sbusBus.c: In function ‘xf86SbusConfigureNewDev’:
../hw/xfree86/common/xf86sbusBus.c:751:21: error: passing argument 1 of ‘XNFasprintf’ from incompatible pointer type [-Wincompatible-pointer-types]
  751 |         XNFasprintf(&GDev->busID, "SBUS:%s", promPath);
      |                     ^~~~~~~~~~~~
      |                     |
      |                     const char **

    Apply the same fix as in commit e1e01d2e ("xfree86/common: Warning fixes. Mostly const string handling.")

Reported downstream in https://bugs.gentoo.org/942506

Edited by Matt Turner

Merge request reports