Skip to content

dix: fix compiler & analyzer warnings from gcc 14.1

Alan Coopersmith requested to merge alanc/xserver:dix-warnings into master
  • dix: check for calloc() failure in Xi event conversion routines
  • dix: PolyText: fully initialize local_closure
  • dix: SetFontPath: don't set errorValue on Success
  • dix: enterleave.c: fix implicit fallthrough warnings
  • dix: CreateScratchGC: avoid dereference of pointer we just set to NULL
  • dix: InitPredictableAccelerationScheme: avoid memory leak on failure
  • dix: dixChangeWindowProperty: don't call memcpy if malloc failed
  • dix: ProcListProperties: skip unneeded work if numProps is 0
  • dix: HashResourceID: use unsigned integers for bit shifting
  • dix: GetPairedDevice: check if GetMaster returned NULL
  • dix: FindBestPixel: fix implicit fallthrough warning

Gets rid of:

  • 1 of 4 [-Wanalyzer-malloc-leak]
  • 3 of 6 [-Wanalyzer-null-dereference]
  • 2 of 2 [-Wanalyzer-possible-null-argument]
  • 12 of 14 [-Wanalyzer-possible-null-dereference]
  • 2 of 2 [-Wanalyzer-use-of-uninitialized-value]
  • 8 of 8 [-Wimplicit-fallthrough=]
  • 1 of 4 [-Wnull-dereference]
  • 1 of 1 [-Wshift-negative-value]

Merge request reports