Skip to content

clean up request length w/ respect to bigreq

Enrico Weigelt, metux IT consult requested to merge metux/xserver:submit/fixup-req-len into master

The authoritative source of the request frame size is client->req_len, especially with big requests larger than 2^18 bytes. But some request handlers are still looking at the length header field (which is zero in case of big requests). Most of the length field swapping is already unneeded - once everybody's looking at client->req_len instead, it can be completely dropped.

This queue is made of three parts:

  1. change all remaining consumers of stuff->length to client->req_len
  2. drop all the now useless swapping of the length fields in the SProc's
  3. drop those SProc's that now became empty (just calling the corresponding Proc's)

Thanks @DemiMarie for hinting me on this issue.

Note: didn't touch the GLX dispatcher, since I can't be sure that all GLX vendors still in use are really looking at client->req_len instead of the length header field.

@aplattner can you tell us about the NV proprietary driver here ?

Merge request reports