Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 944
    • Issues 944
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 123
    • Merge requests 123
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !140

glamor: pixmap FBO may not be allocated

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Olivier Fourdan requested to merge ofourdan/xserver:issue647 into master Mar 08, 2019
  • Overview 3
  • Commits 1
  • Pipelines 2
  • Changes 1

If _glamor_create_tex() fails to allocate the FBO because of GL_OUT_OF_MEMORY error, the pixmap_priv->fbo is NULL.

However, glamor_get_pixmap_texture() doesn't actually check whether the pixmap_priv->fbo is NULL and will segfault with a NULL pointer dereference trying to access the pixmap_priv->fbo->tex.

Signed-off-by: Olivier Fourdan ofourdan@redhat.com Closes: #647 (closed)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: issue647