Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 940
    • Issues 940
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 124
    • Merge requests 124
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !135

glamor: Improve error propagation and fallback paths when running out of GL memory

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Paul Kocialkowski requested to merge PaulKocialkowski/xserver:master into master Mar 04, 2019
  • Overview 10
  • Commits 4
  • Pipelines 2
  • Changes 4

Some systems such as the Raspberry Pi have limited GL memory, which can easily be filled up and result in GL out-of-memory errors in glamor. In such cases, a SEGFAULT would often happen because of a FBO alloc return code not being propagated on error. This is fixed by the first patch of this series. With it, X keeps running and no longer crashes.

The following patches improve error handling and add support for a PBO fallback path.

With that, I can still see some glitches (e.g. missing text after resizing a window) when running out of GL memory, so there is still room for improvement.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: master