Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 940
    • Issues 940
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 124
    • Merge requests 124
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !1057

present: Send a PresentConfigureNotify event for destroyed windows

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Adam Jackson requested to merge ajax/xserver:present-destroy-notify into master Feb 02, 2023
  • Overview 12
  • Commits 1
  • Pipelines 3
  • Changes 3

This is a fix for a deadlock case, where the client ends up blocked waiting for a Present event that will never come because the window was destroyed.

The fix as written is a bit hacky. Clients will simply be sent this new kind of event rather than selecting for a new PresentDestroyNotify, and the values in the event run the risk of making the client do something "illegal", 0x0 isn't a valid size for example. In practice I expect it's fine, most clients are not expecting to survive their GLXWindow being ripped out from under them, which means this simply promotes a deadlock-on-exit to a crash-on-exit.


Posting this for discussion, I don't have a ton of time to follow up on this and I don't really care whether this is sent unconditionally or needs a whole new protocol bump. Frankly if I were bumping the protocol this is a pretty half-assed solution and #1428 is what I'd rather see. Regardless, someone decide and push this across the finish line please.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: present-destroy-notify