Commits on Source (4)
-
We can directly use calloc() as all other places do. If we wanna have an convenient macro for struct allocation, that would be the job of a separate patch queue and should be done consequently, treewide. Signed-off-by:
Enrico Weigelt, metux IT consult <info@metux.net> Part-of: <xorg/xserver!1586>
-
Signed-off-by:
Enrico Weigelt, metux IT consult <info@metux.net> Part-of: <xorg/xserver!1586>
-
../hw/xfree86/os-support/bsd/bsd_init.c: In function ‘xf86CloseConsole’: ../hw/xfree86/os-support/xf86_os_support.h:22:6: error: ‘dispatchException’ undeclared (first use in this function) 22 | if (dispatchException & DE_TERMINATE) { \ | ^~~~~~~~~~~~~~~~~ ../hw/xfree86/os-support/bsd/bsd_init.c:634:13: note: in expansion of macro ‘xf86FatalError’ 634 | xf86FatalError("xf86CloseConsole: KDDISABIO failed (%s)", | ^~~~~~~~~~~~~~ ../hw/xfree86/os-support/xf86_os_support.h:22:6: note: each undeclared identifier is reported only once for each function it appears in 22 | if (dispatchException & DE_TERMINATE) { \ | ^~~~~~~~~~~~~~~~~ ../hw/xfree86/os-support/bsd/bsd_init.c:634:13: note: in expansion of macro ‘xf86FatalError’ 634 | xf86FatalError("xf86CloseConsole: KDDISABIO failed (%s)", | ^~~~~~~~~~~~~~ ../hw/xfree86/os-support/xf86_os_support.h:22:26: error: ‘DE_TERMINATE’ undeclared (first use in this function); did you mean ‘ACTION_TERMINATE’? 22 | if (dispatchException & DE_TERMINATE) { \ | ^~~~~~~~~~~~ ../hw/xfree86/os-support/bsd/bsd_init.c:634:13: note: in expansion of macro ‘xf86FatalError’ 634 | xf86FatalError("xf86CloseConsole: KDDISABIO failed (%s)", | ^~~~~~~~~~~~~~ Signed-off-by:
Enrico Weigelt, metux IT consult <info@metux.net> Part-of: <xorg/xserver!1575>
-
Since commit 792758fa ("xwayland: Update lost focus on deactivation"), in rootful mode, if we receive an "activated" state from xdg-shell indicating that the surface is no longer active, we shall end up calling xwl_seat_leave_ptr(). But xwl_seat_leave_ptr() does not actually check whether the seat has pointer capabilities, and if not, get_pointer_device() will return NULL. As a result, we would crash using a NULL pointer in GetMaster(). This typically can happen when using Xwayland rootful on headless compositors such as "cage" which do not advertise any capabilities for the seat. To avoid the issue, simply check whether get_pointer_device() returns a valid non-null device and bail out early otherwise. Fixes: 792758fa - xwayland: Update lost focus on deactivation Closes: xorg/xserver#1700 Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> Part-of: <xorg/xserver!1590>