Commit de940e06 authored by Peter Harris's avatar Peter Harris
Browse files

xkb: fix key type index check in _XkbSetMapChecks

This code block was moved from a function that returns 0 for failure to a
function that returns 0 for Success in commit

. Change the return value to
BadValue to match the other checks in _XkbSetMapChecks.

Set nTypes to xkb->map->num_types when XkbKeyTypesMask is not set, to
allow requests with the XkbKeyTypesMask flag unset in stuff->present to

Fixes a potential heap smash when client->swapped is true, because the
remainder of the request will not be swapped after "return 0", but
_XkbSetMap will be called anyway (because 0 is Success).
Signed-off-by: Peter Harris's avatarPeter Harris <>
parent 270e4397
Pipeline #112488 passed with stages
in 3 minutes and 42 seconds
......@@ -2419,6 +2419,9 @@ _XkbSetMapChecks(ClientPtr client, DeviceIntPtr dev, xkbSetMapReq * req,
client->errorValue = nTypes;
return BadValue;
else {
nTypes = xkb->map->num_types;
/* symsPerKey/mapWidths must be filled regardless of client-side flags */
map = &xkb->map->key_sym_map[xkb->min_key_code];
......@@ -2429,7 +2432,7 @@ _XkbSetMapChecks(ClientPtr client, DeviceIntPtr dev, xkbSetMapReq * req,
for (w = g = 0; g < ng; g++) {
if (map->kt_index[g] >= (unsigned) nTypes) {
client->errorValue = _XkbErrCode4(0x13, i, g, map->kt_index[g]);
return 0;
return BadValue;
if (mapWidths[map->kt_index[g]] > w)
w = mapWidths[map->kt_index[g]];
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment