Skip to content
Snippets Groups Projects

Fix commit 51a836bf

Closed Alberts Muktupāvels requested to merge (removed):master into master

Commit 51a836bf tried to properly escape -D string defines. This change seems wrong because when quoting option like -D'SOMETHING="something"' it is not needed to escape double quotes.

If mentioned option/define is changed to -D'SOMETHING=\"something\"' it will cause build failure, because compiler will turn printf (SOMETHING); into printf (\"something\"); and will produce missing terminating " character [-Werror] error.

#1 (closed)

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading