Skip to content
Snippets Groups Projects

keysymdef.h: delete four symbolic names that serve no purpose

Merged Ghost User requested to merge (removed):t3 into master
1 unresolved thread

Ten years ago, in commit 6d4acb0e, these four keysyms were added to support new compose sequences that then could be typed with the newish German T3 layout -- or at least, that was the intention.

The commit was in response to https://bugs.freedesktop.org/62189, right before I retracted the patch after learning that there are no precomposed characters that use those four symbols as diacritics.

The commit should have been reverted then, but... it lingered and was forgotten. No layout in xkeyboard-config uses these symbols (obviously, as they serve no purpose) and meanwhile the T3 layout itself has become obsolete [1], so... it's time to clean up.

[1] https://de.wikipedia.org/wiki/DIN_2137#Neufassung_2018

"die Belegung T3 wird nicht mehr definiert, da die Erfahrung gezeigt hat, dass eine solche Tastatur ohnehin nicht produziert wird"

Signed-off-by: Benno Schulenberg bensberg@telfort.nl

Merge request reports

Checking pipeline status.

Merged by Alan CoopersmithAlan Coopersmith 1 year ago (Apr 21, 2023 9:49pm UTC)

Loading

Pipeline #863431 passed

Pipeline passed for cb44799b on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User requested review from @alanc

    requested review from @alanc

  • Alan Coopersmith approved this merge request

    approved this merge request

    • Is it possible te release new version because this MR? :thinking:

    • I think you added this comment to the wrong commit. This MR was already included in the 2023.1 and 2023.2 releases, but why would you need a release that removes unused symbols? Nothing should depend on their removal.

    • I'm at the moment working on some feature addition in FDBuild. It looks like Qt was referencing these symbols: https://gitlab.com/romangg/fdbuild/-/jobs/5292961766#L1078

      A fix for that has landed in Qt some days ago though. Currently I'm trying to find out why my Qt 6 build still fails with this fix on Qt master/dev.

      Anyway I'm just chiming in to let you know that the symbols were "used" in the sense of being referenced in some downstream projects and people having to put in work afterwards to adapt to it.

    • Thanks, and we apologize for the problems in Qt, but that is the opposite sort of dependency - they depended on the symbols being defined, unlike the above comment which was asking for a new release with the symbols removed. (A release that happened 4 months before this comment.)

    • No problem, it's only a minor inconvenience after all. Although also small breaking changes in common software pile up over time and bind work force. So we should be mindful of this.

    • Author Contributor

      Well, if Qt somehow needs to make local copies of many of the Xorgproto key names, then it should keep a close watch on the keysymdef.h file, because symbols may get added, removed, or renamed.

      For example, dead_hamza was recently added, and will soon be used in an xkeyboard-config layout, and if Qt doesn't recognize it...

      Another example: dead_small_schwa and dead_capital_schwa got better names, and one day the old names will be deleted.

    • Please register or sign in to reply
  • Wismill mentioned in merge request !83 (merged)

    mentioned in merge request !83 (merged)

Please register or sign in to reply
Loading