Skip to content
Snippets Groups Projects
Commit d9da580b authored by Tobias Stoeckmann's avatar Tobias Stoeckmann Committed by Matthieu Herrb
Browse files

Protocol handling issues in libXv - CVE-2016-5407


The Xv query functions for adaptors and encodings suffer from out of
boundary accesses if a hostile X server sends a maliciously crafted
response.

A previous fix already checks the received length against fixed values
but ignores additional length specifications which are stored inside
the received data.

These lengths are accessed in a for-loop. The easiest way to guarantee
a correct processing is by validating all lengths against the
remaining size left before accessing referenced memory.

This makes the previously applied check obsolete, therefore I removed
it.

Signed-off-by: default avatarTobias Stoeckmann <tobias@stoeckmann.org>
Reviewed-by: default avatarMatthieu Herrb <matthieu@herrb.eu>
parent cf8cc328
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment