Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • L libXft
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 0
    • Merge requests 0
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

Due to an influx of spam, we have had to impose restrictions on new accounts. Please see this wiki page for instructions on how to get full permissions. Sorry for the inconvenience.

  • xorgxorg
  • lib
  • libXft
  • Merge requests
  • !14

Fix length check in XftTextExtents*

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Adam Sampson requested to merge atsampson/libxft:extentsfix into master Sep 06, 2022
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

Commit 06a3c0ab in libXft 2.3.5 added length checks of the form if (len <= 0) return; to various Xft functions. However, while rendering an empty string is equivalent to doing nothing, asking for the extents of an empty string isn't -- it still needs to fill in the extents structure. This broke text rendering in some applications (e.g. xpdf's Motif GUI).

Check for len < 0 in XftTextExtents* instead.

(If similar changes have been made elsewhere, it'd be worth checking they don't have the same problem...)

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: extentsfix