Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • libxcb libxcb
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 39
    • Issues 39
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 11
    • Merge requests 11
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • lib
  • libxcblibxcb
  • Merge requests
  • !14

Don't insert padding between lists in requests

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Peter Harris requested to merge peterh/libxcb:autopad into master Jan 20, 2021
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

Lists of types that have the same padding as each other should not have any padding automatically inserted by libxcb.

Fixes xcb_randr_set_crtc_gamma when "size" is an odd number.

Incidentally fixes incorrect padding when the request is built out-of-line (as when c_need_serialize is set), not that there are any such requests in the xorg tree that end without padding.

Depends on xorg/proto/xcbproto!14 (merged) in order to avoid breaking xcb_glx_set_client_info_arb and xcb_glx_set_client_info_2arb (and also a couple of xprint requests, not that anybody uses xprint).

Edited Jan 20, 2021 by Peter Harris
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: autopad