Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • libX11 libX11
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 71
    • Issues 71
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 15
    • Merge requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • lib
  • libX11libX11
  • Merge requests
  • !56

Locale locking fixes

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Keith Packard requested to merge keithp/libx11:locale-locking into master Nov 08, 2020
  • Overview 3
  • Commits 4
  • Pipelines 0
  • Changes 4

This is a slightly re-worked set of fixes that was originally authored by Jacek Caban jacek@codeweavers.com in 2017.

  1. Add locking around character set conversion contexts.
  2. Remove some static variables in Xlcmbtowc and _Xlcwctomb
  3. Admit that we can never unload locale context data

The last is the only one I expect to evoke a bit of concern -- we're committing to never releasing memory used by X locale data. The reason for this is pretty simple -- _XlcCurrentLC returns a pointer to locale data which has no bound on lifetime as there's no matching free function. Because of this, I removed all of the reference counting and turned _XCloseLC into a no-op. This latter bit replaces the patch that Jacek wrote which added locking to this function.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: locale-locking