Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • libX11 libX11
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • lib
  • libX11libX11
  • Merge requests
  • !17

makekeys: Detach ourselves from X headers entirely

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Adam Jackson requested to merge ajax/libx11:makekeys-build-fix into master Jun 17, 2019
  • Overview 2
  • Commits 1
  • Changes 1

Subsequent to a121b7b0 we are no longer building makekeys with enough -I/foo/bar to find the X11 headers, so if they're not in a system include path, things fail. Since this utility is only needed at build time, there's no real reason to demand the X headers be installed for both the build and target machines if cross- compiling, we can just assume a vaguely ANSI environment instead.

Reported-by: Zeising on #xorg-devel Reviewed-by: Keith Packard keithp@keithp.com

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: makekeys-build-fix