Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • libX11 libX11
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 68
    • Issues 68
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 9
    • Merge requests 9
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • lib
  • libX11libX11
  • Merge requests
  • !140

Fix Win32 build with -fno-common

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jon Turney requested to merge jturney/libx11:win32-no-common-fix into master Jun 22, 2022
  • Overview 1
  • Commits 1
  • Pipelines 2
  • Changes 1

/work/xorg/lib/libX11/src/XlibInt.c:1968: multiple definition of `_Xdebug_p'; .libs/globals.o:globals.c:(.bss+0xc): first defined here

Avoid redundant definition of _Xdebug_p in globals.c (which is under the influence of _Xdebug being #defined to _Xdebug_p.

This appears to be an ancient hack to work around data exports resolving to the address of the import stub, not the import. (See [1]).

(This is probably no longer needed or can be done in a better way, as per the discussion under --enable-auto-import in the ld manpage.)

[1] https://cygwin.com/pipermail/cygwin-xfree/2001-May/004606.html

Signed-off-by: Jon Turney jon.turney@dronecode.org.uk

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: win32-no-common-fix