Provides automatic integer overflow checking in allocation size calculations
(Though we already have explicit checks before using values provided
 over the protocol in calculations, so many were already manually checked.)
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Wrapper for realloc() that checks for overflow when multiplying
arguments together, so we don't have to add overflow checks to
every single call.  For documentation on usage, see:
http://www.openbsd.org/cgi-bin/man.cgi/OpenBSD-current/man3/calloc.3

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Found by using:
    codespell --builtin clear,rare,usage,informal,code,names
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Also clears up all "Loss of precision on implicit conversion" warnings
from Oracle's Parfait static analyser.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

FSQXInfo.c: In function ‘FSQueryXInfo’:
FSQXInfo.c:110:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (j=0; j<props->num_offsets; j++)
                ^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

FSQXExt.c: In function ‘FSQueryXExtents8’:
FSQXExt.c:105:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (i = 0; i < reply.num_extents; i++) {
                   ^
FSQXExt.c: In function ‘FSQueryXExtents16’:
FSQXExt.c:141:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  for (i = 0; i < str_len; i++) {
                ^
FSQXExt.c:165:19: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (i = 0; i < reply.num_extents; i++) {
                   ^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

FSQGlyphs.c: In function ‘FSQueryXBitmaps8’:
FSQGlyphs.c:113:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (i=0; i<reply.num_chars; i++)
                ^
FSQGlyphs.c: In function ‘FSQueryXBitmaps16’:
FSQGlyphs.c:160:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  for (i = 0; i < str_len; i++) {
                ^
FSQGlyphs.c:198:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (i=0; i<reply.num_chars; i++)
                ^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

FSListCats.c: In function ‘FSListCatalogues’:
FSListCats.c:104:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  for (i = 0; i < rep.num_catalogues; i++) {
                ^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

FSFontInfo.c: In function ‘FSListFontsWithXInfo’:
FSFontInfo.c:182:13: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  for (j=0; j<pi[i]->num_offsets; j++)
             ^
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Mihail Konev authored Jan 26, 2017 and Peter Hutterer committed Jan 26, 2017

Signed-off-by: Mihail Konev <k.mvc@ya.ru>

Emil Velikov authored Mar 09, 2015 and Peter Hutterer committed Jan 26, 2017

Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Parts were indented, others weren't, now is more consistent.
'git diff -w' shows no non-whitespace changes in this commit
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

The contents of pattern are simply copied to the request sent to
the font server and never touched again, so can be labeled read-only.

Fixes compiler warning building xfsinfo:

xfsinfo.c: In function ‘print_catalogue_info’:
xfsinfo.c:158:5: warning: passing argument 2 of ‘FSListCatalogues’ discards
 ‘const’ qualifier from pointer target type [enabled by default]
     char      **cats = FSListCatalogues(svr, "*", 1000, &n);
     ^
In file included from xfsinfo.c:66:0:
FSlib.h:255:16: note: expected ‘char *’ but argument is of type ‘const char *’
 extern char ** FSListCatalogues ( FSServer *svr, char *pattern,
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jasper St. Pierre <jstpierre@mecheye.net>

Since we build with -export-symbols-regex '^FS.*', it wasn't available
to callers outside libFS, and was never called by anything inside libFS.

Seems to have been imported from XlibInt.c without ever being used.

Flagged by cppcheck 1.62:
[FSlibInt.c:753]: (style) The function '_FSWireToEvent' is never used.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jasper St. Pierre <jstpierre@mecheye.net>

Since we build with -export-symbols-regex '^FS.*', it wasn't available
to callers outside libFS, and was never called by anything inside libFS.

Seems to have been imported from XlibInt.c without ever being used.

Flagged by cppcheck 1.62:
[FSlibInt.c:180]: (style) The function '_FSEventsQueued' is never used.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jasper St. Pierre <jstpierre@mecheye.net>

Since we build with -export-symbols-regex '^FS.*', it wasn't available
to callers outside libFS, and was never called by anything inside libFS.

Seems to have been imported from XlibInt.c without ever being used.
The _FSserver fields that it used (and nothing else did) are replaced
with "unused" placeholders to maintain struct layout/size.

Flagged by cppcheck 1.62:
[FSlibInt.c:973]: (style) The function '_FSAllocScratch' is never used.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jasper St. Pierre <jstpierre@mecheye.net>

Since we build with -export-symbols-regex '^FS.*', it wasn't available
to callers outside libFS, and was never called by anything inside libFS.

Xtrans provides it's own exact copy of this function, which gets
the name _FSTransGetHostname when built in libFS, nothing in libFS
outside the Xtrans code calls a gethostname() function.

Flagged by cppcheck 1.62:
[FSlibInt.c:1060]: (style) The function '_FSGetHostname' is never used.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jasper St. Pierre <jstpierre@mecheye.net>

Solaris <sys/errno.h> has:
 #define EWOULDBLOCK       EAGAIN
so checking (errno == EAGAIN || errno == EWOULDBLOCK) is overkill.

This leads cppcheck 1.62 to complain:
[FSlibInt.c:153] -> [FSlibInt.c:153]: (style) Same expression on both sides of '||'.
[FSlibInt.c:301] -> [FSlibInt.c:301]: (style) Same expression on both sides of '||'.
[FSlibInt.c:379] -> [FSlibInt.c:379]: (style) Same expression on both sides of '||'.
[FSlibInt.c:472] -> [FSlibInt.c:472]: (style) Same expression on both sides of '||'.

This quiets it, and reduces the number of calls Solaris Studio cc
generates to the __errno() function to get the thread-specific errno value.
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jasper St. Pierre <jstpierre@mecheye.net>

Suggested by cppcheck 1.62
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

FSOpenServ.c:266:5: warning: Use of memory after it is freed
    OutOfMemory(svr, setup);
    ^~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

FSOpenServ.c:183:3: warning: Function call argument is an uninitialized value
                FSfree(alts[i].name);
                ^~~~~~~~~~~~~~~~~~~~
./FSlibos.h:273:21: note: expanded from macro 'FSfree'
                    ^~~~~~~~~~~
Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

Required on Solaris to expose fd_mask in <sys/select.h> now that
xtrans 1.3 defines _XOPEN_SOURCE to 600 on Solaris, since fd_mask
is not defined in that version of the XPG standards.

Fixes build failure:
../../src/FSConnServ.c: In function '_FSWaitForWritable':
../../src/FSConnServ.c:166:6: error: 'fd_mask' undeclared (first use in this function)
../../src/FSConnServ.c:166:6: note: each undeclared identifier is reported only once for each function it appears in
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>

->Readv was in fact being used, oops.  Just call straight down to
readv() instead.
Reviewed-by: Peter Harris <pharris@opentext.com>
Signed-off-by: Adam Jackson <ajax@redhat.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>