Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • X xf86-video-qxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • driver
  • xf86-video-qxl
  • Merge requests
  • !9

Fix compatibility with xorg-server 21.1.3

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Joe Breuer requested to merge jmbreuer/xf86-video-qxl:fix-xorg-server-21 into master Apr 12, 2022
  • Overview 5
  • Commits 3
  • Pipelines 3
  • Changes 2

xf86-video-qxl as it is does not work with xorg-server 21.1.3 (21.x from the looks of it). For the most part, now required fields are not initialized, leading to SEGFAULTs when trying to initialize the driver.

I tracked down three issues, with this patch xf86-video-qxl works for me.

  1. pScrn->modes now needs to be set (correctly), it is/should be the same as qxl->x_modes
  2. pScrn->currentMode is not initialized, so take width and height from qxl->primary_mode.x_res and .y_res
  3. qxl_init_randr() is required to initialize RandR attributes, but only does so if num_heads is at least 1. So, initialize qxl->num_heads to 1 if no option is given.

This is what I found and seemed obvious / plausible to me following up where the code breaks. I'm by no means an expert on X driver code. Nonetheless, this is a working solution for me and could be used by others until possibly a more proper fix is generally available.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-xorg-server-21