Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Register
  • Sign in
  • X xf86-video-qxl
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Issues 15
    • Issues 15
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • driver
  • xf86-video-qxl
  • Merge requests
  • !6

Fix a build error with Xorg master

  • Review changes

  • Download
  • Patches
  • Plain diff
Merged Zoltán Böszörményi requested to merge zboszor/xf86-video-qxl:fix-build-with-new-xserver into master Aug 28, 2021
  • Overview 1
  • Commits 1
  • Pipelines 0
  • Changes 2

Use xf86ReturnOptValBool() in get_bool_option() instead of options[option_index].value.bool to fix a compiler error with current Xorg xserver master branch.

Also use xf86GetOptValInteger() in get_int_option() and xf86GetOptValString() in get_str_option() for consistency.

The change causes a slight performance drop during option parsing because the passed-in index_value is no longer used as an index into the options array.

Instead, it's used as a token now for the standard option getter functions which works since the index_value to the get_*_option() functions are identical to the value of options[n].token in the passed-in OptionInfoRec array.

Also rename "int option_index" to "int token" for clarity in all three functions.

Signed-off-by: Zoltán Böszörményi zboszor@gmail.com

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-build-with-new-xserver