Skip to content

Correct a long standing led state bug in XSpice.

Jeremy White requested to merge jwhite/xf86-video-qxl:master into master

The CtrlProc for our keyboard driver incorrectly mapped the device private to a SpiceKbd* intead of to a InputInfoPtr.

That resulted in led state being written into the driver name for our driver structure, instead of into the led state.

That, in turn, led to a cool bug where if you pressed caps lock, the two second sync timer in the spice server would cause it to attempt to correct the state by pressing caps lock to get the states to match. Since the states will never match, the caps lock effectively cycles on and off every two seconds.

Merge request reports