Skip to content

Fixes warning: implicit declaration of function

Sérgio Basto requested to merge sergiomb/xf86-video-nouveau:implict_function into master

nv_driver.c:1443:9: warning: implicit declaration of function ‘wfbScreenInit’; did you mean ‘fbScreenInit’? [-Wimplicit-function-declaration] ret = wfbScreenInit(pScreen, FBStart, pScrn->virtualX, ^~~~~~~~~~~~~ fbScreenInit

In commit sergiomb/xf86-video-nouveau@794a2772 "nv50: use libwfb for pixmap access when driver pixmaps enabled", authored 15 years ago, it is missing the declaration of wfbScreenInit

This warning was harmless until Gcc and Modern C make implicit "declaration of function" an error.

We got several attempts to fix this, one is this commit [1] which is in Xwayland branch but not in xorg-x11-server branch and IMO should be reverted.

[1] xorg/xserver@34a430a1

Signed-off-by: Sérgio M. Basto sergio@serjux.com

Merge request reports