Skip to content

Remove MGA_NOT_HAL() macro left behind from HAL removal

Alan Coopersmith requested to merge alanc/xf86-video-mga:MGA_NOT_HAL into master

When commit 94bbeb13 removed the HAL support, it removed the MGA_HAL() macro to wrap code only used with HAL, but left behind the equivalent MGA_NO_HAL() macro for the non-HAL code paths. Since it just expanded to the code it contained, it did nothing but upset clang and mess up the code formatting.

This fixes 6 clang warnings of the form:

mga_dacG.c:1670:2: warning: embedding a directive within macro arguments
 has undefined behavior [-Wembedded-directive]
 ^

and 23 clang warnings of the form:

mga_dacG.c:1351:3: warning: empty expression statement has no effect;
 remove unnecessary ';' to silence this warning [-Wextra-semi-stmt]
        );      /* MGA_NOT_HAL */
         ^

Signed-off-by: Alan Coopersmith

Merge request reports